838006 - [E-Mail][User Story] E-Mail image attachment

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P1)

Description

[Peter Dolanjski [:pdol]]

UCID: Email-138

User Story:
As a user, I want to be able to attach one or more image files (based on currently supported MIME types) to new emails or within replies to emails so that I can share content with my recipients.

Comment 1

[Rob MacDonald [:robmac]]

Attachment: draft email attachment flows from Gallery, Videos, Music, Camera and Contacts

Proposed flows for attachments from Gallery, Video and Music. Also contains some recommended features that are not currently requirements, including creating attachments from Contacts and Camera.

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

as dkuo took bug Bug 836497, assign this one to dkuo. 
if anyone has already started working on it, you may discuss with dkuo to take this

Comment 4

[Rob MacDonald [:robmac]]

This flows have been updated and placed on drop box here:

https://www.dropbox.com/s/5giljes7ao9gyrg/email-attachments.pdf

Two items to flag in this version...

First, the selection tools for video, contacts and music will likely only allow users to pick one file at a time. For long lists, we felt that the UX for multiple selections might become overly complex. As a result, if a user wants to attach multiple files, they would need to attach a second file from the message view add attachment "+" button. The screens will be updated this week to reflect this.

Second, the spec contains a proposal for a document manager to handle unrecognized attachment types. This would allow users to save, forward and delete attachments that are not compatible with the core set of apps. This is not in scope and is for discussion purposes only.

Comment 5

[Dominic Kuo [:dkuo]]

Attachment: Modify gallery and email to support attaching image files from picker

Andrew and David,

This patch modify both email and gallery app, so I think it will be better for this patch to be reviewed by both of you, thanks.

Comment 6

[Dominic Kuo [:dkuo]]

Comment on attachment 721361 [details]
Modify gallery and email to support attaching image files from picker

It seems that there are too many review requests for David, so I will cancel this one first for David to ease his task loading.

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 721361 [details]
Modify gallery and email to support attaching image files from picker

Thanks for the patch!  This is looking pretty good, but we need to address the localization issue and providing default filenames for camera/wallpaper before I can sign off.  Please request review again when that's fixed up.

Comment 8

[Dominic Kuo [:dkuo]]

Comment on attachment 721361 [details]
Modify gallery and email to support attaching image files from picker

Andrew, I have update my patch base on your comments.

The localization issue is fixed by using the plural functionality of l10n.js.
(Actually I didn't know we have the plural functionality before you told me! thanks)

And the issue of the default filenames for camera/wallpaper is also fixed, for the blobs from camera/wallpaper, they do have names, we just need to pass it in the activity object, so that's how I fixed it.

It's still possible that we are unable get the name field from data.blob.name or data.name, but it won't be a problem to this user story, so I filed bug 848855 to record it and we can fix that later, after ux define it.

Comment 9

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 721361 [details]
Modify gallery and email to support attaching image files from picker

r=asuth.  The styling of the aggregate file size is a little wonky, but we'll leave that up to visual design to fix.  Apologies about the delay on the follow-up review; things have been crazy and it fell through the cracks.  Please do feel free to ping me if I'm letting a review linger and I haven't explicitly given an ETA on when I'll get to the review!

I'll merge this now.

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

landed on gaia/master:
https://github.com/mozilla-b2g/gaia/pull/8475
https://github.com/mozilla-b2g/gaia/commit/8311004db39832b7478b357be76e476944b3ba4b

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Andrew, do we still want this uplifted?

Comment 12

[Julien Wajsberg [:julienw]]

v1.0.1: landed but disabled in Bug 851124
will land in v1.1 tomorrow at the latest.

Comment 13

[Julien Wajsberg [:julienw]]

Landed in v1-train as part of Bug 851124 big uplift.

Comment 14

[Jason Smith [:jsmith]]

I believe we have test case coverage for this, right?

Comment 15

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Forgot to flip the bit: #6893

bug 855890 was found when testing.

Marking as verified.  Note that attachments received by hotmail is not recognized as images, because the extension wasn't preserved (see bug 855890)

Comment 16

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/f9f11b8cbf8a
Gaia   663101b6eb809383e5882d9bc3868a923a57998a
BuildID 20130401070203
Version 18.0

Comment 17

[Julien Wajsberg [:julienw]]

will uplift this properly tomorrow.

Comment 18

[Julien Wajsberg [:julienw]]

v1-train: 433db9c80066986e6597346f3c20f3b249f86e29

should be really fixed now, but please test properly as there were conflicts in the gallery.

Comment 19

[Stephany Wilkes]

Rob and Przemek have been working on the UX for this, in the bugs I've added that block this one. We expect completion on VxD early next week (April 22-23, 2013).

This cannot ship as currently implemented.

Comment 21

[Tracy Walker [:tracy]]

verified fixed on Leo with:

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/0c71cbc5fe0c
Gaia   a7b0810580afc734f3d5e441914fe895f9c1923e
BuildID 20130508230207
Version 18.0